plugable secret backend #34157
Merged
plugable secret backend #34157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing secret driver serialization issue from 08f7cf0 Signed-off-by: Liron Levin <[email protected]>
liron-l
pushed a commit
to twistlock/cli
that referenced
this pull request
Jul 18, 2017
This commit extends SwarmKit secret management with pluggable secret backends support. Following previous commits: 1. moby/swarmkit@eebac27 2. moby/moby@08f7cf0 Added driver parameter to `docker secret` command. Specifically: 1. `docker secret create [secret_name] --driver [driver_name]` 2. Displaying the driver in ``` $ docker secret ls $ docker secret inspect [secret_name] $ docker secret inspect [secret_name] -pretty ``` There is a bug in serialization of the secret data. Handled in moby/moby#34157. Signed-off-by: Liron Levin <[email protected]>
liron-l
pushed a commit
to twistlock/cli
that referenced
this pull request
Jul 18, 2017
This commit extends SwarmKit secret management with pluggable secret backends support. Following previous commits: 1. moby/swarmkit@eebac27 2. moby/moby@08f7cf0 Added driver parameter to `docker secret` command. Specifically: 1. `docker secret create [secret_name] --driver [driver_name]` 2. Displaying the driver in ``` $ docker secret ls $ docker secret inspect [secret_name] $ docker secret inspect [secret_name] -pretty ``` There is a bug in serialization of the secret data. Handled in moby/moby#34157. Signed-off-by: Liron Levin <[email protected]>
liron-l
pushed a commit
to twistlock/cli
that referenced
this pull request
Jul 18, 2017
This commit extends SwarmKit secret management with pluggable secret backends support. Following previous commits: 1. moby/swarmkit@eebac27 2. moby/moby@08f7cf0 Added driver parameter to `docker secret` command. Specifically: 1. `docker secret create [secret_name] --driver [driver_name]` 2. Displaying the driver in ``` $ docker secret ls $ docker secret inspect [secret_name] $ docker secret inspect [secret_name] -pretty ``` There is a bug in serialization of the secret data. Handled in moby/moby#34157. Signed-off-by: Liron Levin <[email protected]>
thaJeztah
approved these changes
Jul 18, 2017
liron-l
pushed a commit
to twistlock/cli
that referenced
this pull request
Jul 18, 2017
This commit extends SwarmKit secret management with pluggable secret backends support. Following previous commits: 1. moby/swarmkit@eebac27 2. moby/moby@08f7cf0 Added driver parameter to `docker secret` command. Specifically: 1. `docker secret create [secret_name] --driver [driver_name]` 2. Displaying the driver in ``` $ docker secret ls $ docker secret inspect [secret_name] $ docker secret inspect [secret_name] -pretty ``` There is a bug in serialization of the secret data. Handled in moby/moby#34157. Signed-off-by: Liron Levin <[email protected]>
liron-l
pushed a commit
to twistlock/cli
that referenced
this pull request
Jul 18, 2017
This commit extends SwarmKit secret management with pluggable secret backends support. Following previous commits: 1. moby/swarmkit@eebac27 2. moby/moby@08f7cf0 Added driver parameter to `docker secret` command. Specifically: 1. `docker secret create [secret_name] --driver [driver_name]` 2. Displaying the driver in ``` $ docker secret ls $ docker secret inspect [secret_name] $ docker secret inspect [secret_name] -pretty ``` There is a bug in serialization of the secret data. Handled in moby/moby#34157. Signed-off-by: Liron Levin <[email protected]>
liron-l
pushed a commit
to twistlock/cli
that referenced
this pull request
Jul 18, 2017
This commit extends SwarmKit secret management with pluggable secret backends support. Following previous commits: 1. moby/swarmkit@eebac27 2. moby/moby@08f7cf0 Added driver parameter to `docker secret` command. Specifically: 1. `docker secret create [secret_name] --driver [driver_name]` 2. Displaying the driver in ``` $ docker secret ls $ docker secret inspect [secret_name] $ docker secret inspect [secret_name] -pretty ``` There is a bug in serialization of the secret data. Handled in moby/moby#34157. Signed-off-by: Liron Levin <[email protected]>
liron-l
pushed a commit
to twistlock/cli
that referenced
this pull request
Jul 18, 2017
This commit extends SwarmKit secret management with pluggable secret backends support. Following previous commits: 1. moby/swarmkit@eebac27 2. moby/moby@08f7cf0 Added driver parameter to `docker secret` command. Specifically: 1. `docker secret create [secret_name] --driver [driver_name]` 2. Displaying the driver in ``` $ docker secret ls $ docker secret inspect [secret_name] $ docker secret inspect [secret_name] -pretty ``` There is a bug in serialization of the secret data. Handled in moby/moby#34157. Signed-off-by: Liron Levin <[email protected]>
liron-l
pushed a commit
to twistlock/cli
that referenced
this pull request
Jul 18, 2017
This commit extends SwarmKit secret management with pluggable secret backends support. Following previous commits: 1. moby/swarmkit@eebac27 2. moby/moby@08f7cf0 Added driver parameter to `docker secret` command. Specifically: 1. `docker secret create [secret_name] --driver [driver_name]` 2. Displaying the driver in ``` $ docker secret ls $ docker secret inspect [secret_name] $ docker secret inspect [secret_name] -pretty ``` There is a bug in serialization of the secret data. Handled in moby/moby#34157. Signed-off-by: Liron Levin <[email protected]>
liron-l
pushed a commit
to twistlock/cli
that referenced
this pull request
Jul 18, 2017
This commit extends SwarmKit secret management with pluggable secret backends support. Following previous commits: 1. moby/swarmkit@eebac27 2. moby/moby@08f7cf0 Added driver parameter to `docker secret` command. Specifically: 1. `docker secret create [secret_name] --driver [driver_name]` 2. Displaying the driver in ``` $ docker secret ls $ docker secret inspect [secret_name] $ docker secret inspect [secret_name] -pretty ``` There is a bug in serialization of the secret data. Handled in moby/moby#34157. Signed-off-by: Liron Levin <[email protected]>
liron-l
pushed a commit
to twistlock/cli
that referenced
this pull request
Jul 18, 2017
This commit extends SwarmKit secret management with pluggable secret backends support. Following previous commits: 1. moby/swarmkit@eebac27 2. moby/moby@08f7cf0 Added driver parameter to `docker secret` command. Specifically: 1. `docker secret create [secret_name] --driver [driver_name]` 2. Displaying the driver in ``` $ docker secret ls $ docker secret inspect [secret_name] $ docker secret inspect [secret_name] -pretty ``` There is a bug in serialization of the secret data. Handled in moby/moby#34157. Signed-off-by: Liron Levin <[email protected]>
liron-l
pushed a commit
to twistlock/cli
that referenced
this pull request
Jul 18, 2017
This commit extends SwarmKit secret management with pluggable secret backends support. Following previous commits: 1. moby/swarmkit@eebac27 2. moby/moby@08f7cf0 Added driver parameter to `docker secret` command. Specifically: 1. `docker secret create [secret_name] --driver [driver_name]` 2. Displaying the driver in ``` $ docker secret ls $ docker secret inspect [secret_name] $ docker secret inspect [secret_name] -pretty ``` There is a bug in serialization of the secret data. Handled in moby/moby#34157. Signed-off-by: Liron Levin <[email protected]>
liron-l
pushed a commit
to twistlock/cli
that referenced
this pull request
Jul 19, 2017
This commit extends SwarmKit secret management with pluggable secret backends support. Following previous commits: 1. moby/swarmkit@eebac27 2. moby/moby@08f7cf0 Added driver parameter to `docker secret` command. Specifically: 1. `docker secret create [secret_name] --driver [driver_name]` 2. Displaying the driver in ``` $ docker secret ls $ docker secret inspect [secret_name] $ docker secret inspect [secret_name] -pretty ``` There is a bug in serialization of the secret data. Handled in moby/moby#34157. Signed-off-by: Liron Levin <[email protected]>
liron-l
pushed a commit
to twistlock/cli
that referenced
this pull request
Jul 19, 2017
This commit extends SwarmKit secret management with pluggable secret backends support. Following previous commits: 1. moby/swarmkit@eebac27 2. moby/moby@08f7cf0 Added driver parameter to `docker secret` command. Specifically: 1. `docker secret create [secret_name] --driver [driver_name]` 2. Displaying the driver in ``` $ docker secret ls $ docker secret inspect [secret_name] $ docker secret inspect [secret_name] -pretty ``` There is a bug in serialization of the secret data. Handled in moby/moby#34157. Signed-off-by: Liron Levin <[email protected]>
liron-l
pushed a commit
to twistlock/cli
that referenced
this pull request
Jul 19, 2017
This commit extends SwarmKit secret management with pluggable secret backends support. Following previous commits: 1. moby/swarmkit@eebac27 2. moby/moby@08f7cf0 Added driver parameter to `docker secret` command. Specifically: 1. `docker secret create [secret_name] --driver [driver_name]` 2. Displaying the driver in ``` $ docker secret ls $ docker secret inspect [secret_name] $ docker secret inspect [secret_name] -pretty ``` 3. Add driver parameter to secrets in `docker-compose`. There is a bug in serialization of the secret data. Handled in moby/moby#34157. Signed-off-by: Liron Levin <[email protected]>
liron-l
pushed a commit
to twistlock/cli
that referenced
this pull request
Jul 19, 2017
This commit extends SwarmKit secret management with pluggable secret backends support. Following previous commits: 1. moby/swarmkit@eebac27 2. moby/moby@08f7cf0 Added driver parameter to `docker secret` command. Specifically: 1. `docker secret create [secret_name] --driver [driver_name]` 2. Displaying the driver in ``` $ docker secret ls $ docker secret inspect [secret_name] $ docker secret inspect [secret_name] -pretty ``` 3. Add driver parameter to secrets in `docker-compose`. There is a bug in serialization of the secret data. Handled in moby/moby#34157. Signed-off-by: Liron Levin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing secret driver serialization issue in secret driver (08f7cf0).
Signed-off-by: Liron Levin [email protected]
- What I did
Fixed serialization issue in secret driver.
- How I did it
- How to verify it
Verified integration with docker cli.