Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit support for macvlan networks to bash completion #24861

Merged
merged 1 commit into from
Jul 21, 2016

Conversation

albers
Copy link
Member

@albers albers commented Jul 20, 2016

Bash completion grabs the available network drivers from the output of docker info.
Unfortionally, the macvlan network driver will not appear there unless a network was created using it, see #24798 (comment).

This PR explicitly adds this driver to the computed driver list so that it is always available.
Note that this is a workaround until the upcoming plugin system is available.

Please schedule for 1.12.0.

@albers albers changed the title Add manual support for macvlan networks to bash completion Add explicit support for macvlan networks to bash completion Jul 20, 2016
@thaJeztah
Copy link
Member

Should we add ipvlan as well here?

@albers
Copy link
Member Author

albers commented Jul 20, 2016

Could not find it in the release notes. Did it also exit experimental?

@thaJeztah
Copy link
Member

I think it did, but good question 😄 I'm running an experimental version, let me quickly check :)

@albers
Copy link
Member Author

albers commented Jul 20, 2016

It's not in current master:

root@8b3519213a48:~# docker network create -d ipvlan some-network
Error response from daemon: plugin not found

root@8b3519213a48:~# docker version
Client:
 Version:      1.12.0-dev
 API version:  1.25
 Go version:   go1.6.3
 Git commit:   a9ca19f
 Built:        Wed Jul 20 19:45:23 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.12.0-dev
 API version:  1.25
 Go version:   go1.6.3
 Git commit:   a9ca19f
 Built:        Wed Jul 20 19:45:23 2016
 OS/Arch:      linux/amd64

@thaJeztah
Copy link
Member

Looks like you're right; it's only macvlan #23524

@thaJeztah
Copy link
Member

LGTM!

@vdemeester
Copy link
Member

LGTM 🐸

@vdemeester vdemeester merged commit d458abc into moby:master Jul 21, 2016
@albers albers deleted the completion-network-driver-macvlan branch July 21, 2016 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants