Add a method to retrieve the interfaces in a sandbox #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hui Kang [email protected]
huikang
force-pushed
the
huikang-patch
branch
from
db65f1d to
d1cd203
Compare
| @@ -36,6 +36,8 @@ type Sandbox interface { | |||
| SetKey(key string) error | |||
| // Delete destroys this container after detaching it from all connected endpoints. | |||
| Delete() error | |||
| // Retrieve the interfaces in the sandbox, for restoring checkpointed container | |||
| Interfaces() []osl.Interface | |||
There was a problem hiding this comment.
though Interface is exposed as an osl interface, it feels odd to include it as part of the API.
osl is purely an internal implementation that provides os layer abstraction away from the clients.
Having this interface exposed via Interfaces() API which gives more control over life-cycle of the interface such as Remove makes me uncomfortable.
Lets hear from @mrjana on his opinion.
|
@huikang It has been detected that this issue has not received any activity in over 6 months. Can you please let us know if it is still relevant:
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hui Kang [email protected]