Have parser error on dockerfiles without instructions #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
reviewed
Jan 4, 2019
See moby/moby#38487 for more discussion. Signed-off-by: Natasha Jarus <[email protected]>
tonistiigi
approved these changes
Jan 4, 2019
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Jan 16, 2019
See moby/buildkit#771 Signed-off-by: Natasha Jarus <[email protected]> Upstream-commit: d104a750f9dfcd58b95b0142197a69cc4eca3bc0 Component: engine
adhulipa
pushed a commit
to adhulipa/docker
that referenced
this pull request
Apr 11, 2019
See moby/buildkit#771 Signed-off-by: Natasha Jarus <[email protected]>
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Apr 20, 2019
…branch) full diff: https://github.com/moby/buildkit/compare/520201006c9dc676da9cf9655337ac711f7f127d..05766c5c21a1e528eeb1c3522b2f05493fe9ac47 - moby/buildkit#952 [18.09 backport] Have parser error on dockerfiles without instructions - backport of moby/buildkit#771 Have parser error on dockerfiles without instructions Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Jun 18, 2019
…branch) - moby/buildkit#952 [18.09 backport] Have parser error on dockerfiles without instructions - backport of moby/buildkit#771 Have parser error on dockerfiles without instructions Signed-off-by: Sebastiaan van Stijn <[email protected]>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Jun 18, 2019
…branch) full diff: https://github.com/moby/buildkit/compare/520201006c9dc676da9cf9655337ac711f7f127d..05766c5c21a1e528eeb1c3522b2f05493fe9ac47 - moby/buildkit#952 [18.09 backport] Have parser error on dockerfiles without instructions - backport of moby/buildkit#771 Have parser error on dockerfiles without instructions Signed-off-by: Sebastiaan van Stijn <[email protected]> Upstream-commit: 65b28186fc4172670b3279e882429496dcbe7ce6 Component: cli
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Jun 18, 2019
…branch) - moby/buildkit#952 [18.09 backport] Have parser error on dockerfiles without instructions - backport of moby/buildkit#771 Have parser error on dockerfiles without instructions Signed-off-by: Sebastiaan van Stijn <[email protected]> Upstream-commit: a1d76e0585c498f5167b28b9909fd8c88fd3370d Component: engine
ingvagabund
added a commit
to ingvagabund/oc
that referenced
this pull request
Jul 3, 2024
ingvagabund
added a commit
to ingvagabund/oc
that referenced
this pull request
Jul 3, 2024
ingvagabund
added a commit
to ingvagabund/oc
that referenced
this pull request
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker buildpanics on a dockerfile with no instructions (e.g., a dockerfile that contains only comments). This patch produces a parse error for such a dockerfile -- we detect this by determining whether the root AST node has an invalid "StartLine" position.See moby/moby#38487 for more discussion.