[v0.17] cherry-picks for v0.17.1 #5499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tonistiigi
commented
Nov 7, 2024
tonistiigi
commented
- dockerfile: fix running onbuild rules from inherited stages #5490
When inheriting from a stage in the same Dockerfile, if that stage defines ONBUILD rules then they should execute as they would if the parent stage would be first built into standalone image and then that image used as a base. This restores the behavior before BuildKit v0.17.0. Signed-off-by: Tonis Tiigi <[email protected]> (cherry picked from commit 5d3589f)
jsternberg
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.