Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/tracing: switch to semconv v0.21.0 #5460

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

thaJeztah
Copy link
Member

Align the package to use the same version of semconv we use elsewhere. Worth noting that some modules still use v0.17;

  • go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc
  • go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace
  • go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp

Git grep on buildkit;

util/tracing/detect/resource.go:                                                                                      semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
util/tracing/tracing.go:                                                                                              semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/github.com/containerd/containerd/tracing/tracing.go:                                                           semconv "go.opentelemetry.io/otel/semconv/v1.21.0"

vendor/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/config.go:                         semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/interceptor.go:                    semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/internal/parse.go:                 semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/semconv.go:                        semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/stats_handler.go:                  semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace/clienttrace.go:                   semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace/httptrace.go:                     semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace/internal/semconvutil/httpconv.go: semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace/internal/semconvutil/netconv.go:  semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/handler.go:                                      semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/internal/semconvutil/httpconv.go:                semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/internal/semconvutil/netconv.go:                 semconv "go.opentelemetry.io/otel/semconv/v1.17.0"

vendor/go.opentelemetry.io/otel/exporters/jaeger/jaeger.go:                                                           semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
vendor/go.opentelemetry.io/otel/sdk/resource/builtin.go:                                                              semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
vendor/go.opentelemetry.io/otel/sdk/resource/container.go:                                                            semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
vendor/go.opentelemetry.io/otel/sdk/resource/env.go:                                                                  semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
vendor/go.opentelemetry.io/otel/sdk/resource/host_id.go:                                                              semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
vendor/go.opentelemetry.io/otel/sdk/resource/os.go:                                                                   semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
vendor/go.opentelemetry.io/otel/sdk/resource/process.go:                                                              semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
vendor/go.opentelemetry.io/otel/sdk/trace/span.go:                                                                    semconv "go.opentelemetry.io/otel/semconv/v1.21.0"

Align the package to use the same version of semconv we use elsewhere. Worth
noting that some modules still use v0.17;

- go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc
- go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace
- go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp

Git grep on buildkit;

    util/tracing/detect/resource.go:                                                                                      semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
    util/tracing/tracing.go:                                                                                              semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
    vendor/github.com/containerd/containerd/tracing/tracing.go:                                                           semconv "go.opentelemetry.io/otel/semconv/v1.21.0"

    vendor/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/config.go:                         semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
    vendor/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/interceptor.go:                    semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
    vendor/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/internal/parse.go:                 semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
    vendor/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/semconv.go:                        semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
    vendor/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/stats_handler.go:                  semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
    vendor/go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace/clienttrace.go:                   semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
    vendor/go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace/httptrace.go:                     semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
    vendor/go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace/internal/semconvutil/httpconv.go: semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
    vendor/go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace/internal/semconvutil/netconv.go:  semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
    vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/handler.go:                                      semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
    vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/internal/semconvutil/httpconv.go:                semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
    vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/internal/semconvutil/netconv.go:                 semconv "go.opentelemetry.io/otel/semconv/v1.17.0"

    vendor/go.opentelemetry.io/otel/exporters/jaeger/jaeger.go:                                                           semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
    vendor/go.opentelemetry.io/otel/sdk/resource/builtin.go:                                                              semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
    vendor/go.opentelemetry.io/otel/sdk/resource/container.go:                                                            semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
    vendor/go.opentelemetry.io/otel/sdk/resource/env.go:                                                                  semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
    vendor/go.opentelemetry.io/otel/sdk/resource/host_id.go:                                                              semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
    vendor/go.opentelemetry.io/otel/sdk/resource/os.go:                                                                   semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
    vendor/go.opentelemetry.io/otel/sdk/resource/process.go:                                                              semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
    vendor/go.opentelemetry.io/otel/sdk/trace/span.go:                                                                    semconv "go.opentelemetry.io/otel/semconv/v1.21.0"

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@crazy-max crazy-max merged commit 952ac2a into moby:master Nov 6, 2024
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants