dockerfile/linter: check for nil linter in linter functions #4996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
reviewed
Jun 5, 2024
| @@ -209,7 +207,7 @@ func parseKvps(args []string, cmdName string, location []parser.Range, lint *lin | |||
| return nil, errBlankCommandNames(cmdName) | |||
| } | |||
| name, value, sep := args[j], args[j+1], args[j+2] | |||
| if sep == "" { | |||
| if lint != nil && sep == "" { | |||
There was a problem hiding this comment.
This looks inconsistent with other lines
There was a problem hiding this comment.
Fixed. It wasn't near the other ones so I didn't see it.
vvoland
approved these changes
Jun 5, 2024
During parsing, the linter can be nil and linter rules won't succeed at running due to a nil dereference. Instead of checking for nil everywhere, this modifies the linter to automatically disable itself if the linter is nil. Fixes a nil dereference panic happening when parsing `ENV` and `LABEL` commands without a linter introduced by 6cfa459. Co-authored-by: Paweł Gronowski <[email protected]> Signed-off-by: Jonathan A. Sternberg <[email protected]>
jsternberg
force-pushed
the
linter-nilcheck
branch
from
89043ad
to
f4cff87
Compare
tonistiigi
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During parsing, the linter can be nil and linter rules won't succeed at running due to a nil dereference. Instead of checking for nil everywhere, this modifies the linter to automatically disable itself if the linter is nil.
Fixes a nil dereference panic happening when parsing
ENVandLABELcommands without a linter introduced by6cfa459.
An alternative to #4984.