Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dockerfile: fix COPY —link to keep previous llb state #2672

Merged
merged 1 commit into from
Feb 23, 2022
Merged

dockerfile: fix COPY —link to keep previous llb state #2672

merged 1 commit into from
Feb 23, 2022

Conversation

tonistiigi
Copy link
Member

Signed-off-by: Tonis Tiigi [email protected]

@tonistiigi tonistiigi requested a review from sipsma February 23, 2022 19:10
sipsma
sipsma approved these changes Feb 23, 2022
View reviewed changes
Copy link
Collaborator

@sipsma sipsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but will all users of LLB need to deal with this same issue when merging platform specific inputs? Just wondering if there's other improvements we can make after this PR

@tonistiigi
Copy link
Member Author

@sipsma I guess easiest would be to just replace func Merge() with func(s State) Merge(). Or maybe NewMergePoint() maybe is less confusing. If users want previous behavior they would do llb.Scratch().Merge()

@tonistiigi tonistiigi merged commit b124b0c into moby:master Feb 23, 2022
@tonistiigi tonistiigi mentioned this pull request Feb 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sipsma sipsma sipsma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonistiigi @sipsma