Move config parsing to a dedicated pkg

[crazy-max]

We can't use the buildkitd config from cmd so move it to util. The idea will be to be able to load the toml configuration from buildx in a follow-up in order to inject the root ca and user tls certs when we create a builder with the docker-container driver.

Signed-off-by: CrazyMax [email protected]

[tonistiigi]

A package that contains the buildkit specific configuration structures should not be in util. cmd/buildkitd seems like a correct place. I'm fine with separating packages though. Would be better if toml parsing and config definition is not in same package but with the current split I'd at least hope that we can leave the containerd/userns dependency out of here.

[crazy-max]

A package that contains the buildkit specific configuration structures should not be in util

Ok I thought it was fine like appcontext and appdefaults.

I'd at least hope that we can leave the containerd/userns dependency out of here.

Moved to cmd/buildkit so now dep is removed in appconfig.

[tonistiigi]

appcontext is not buildkit specific. It is used by other projects and potentially helpful for any cli tool.

appdefaults correct, shouldn't be under util as well. Or the buildkit specifics should be passed as parameters.

[crazy-max]

@tonistiigi Ok now toml parsing is in its own pkg and moved back config to cmd/buildkitd/config.

[crazy-max]

@tonistiigi Moved to ./config. Also moved the resolver config in ./config so we don't depend on the resolver if we only want to use the config.

[tonistiigi]

• avoid creating new top level packages if there isn't a clear need for them. Config is for buildkitd, there is no buildkit-config.
• everything under util shouldn't be implementing buildkit-only feature logic. It should not generally import anything other than vendor and other util packages.
• under cmd/buildkitd you can split current logic into multiple packages as you wish

[tonistiigi]

It's generally better to have a pkg that only defines the config structures and no dependency on toml parsing but we can fix that in follow-up if it comes up.