Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolver: avoid error caching on token fetch #1957

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

tonistiigi
Copy link
Member

@tonistiigi tonistiigi commented Jan 28, 2021

fixes #1928
closes #1933

Signed-off-by: Tonis Tiigi [email protected]

@tonistiigi tonistiigi marked this pull request as ready for review January 28, 2021 18:01
@tonistiigi
Copy link
Member Author

@vladaionescu @alexcb I think this should fix the issue with the error getting stuck while still sharing tokens with parallel requesters. PTAL

Copy link
Contributor

@vladaionescu vladaionescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand this correctly, this no longer caches any error as a result of fetching the token.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: i/o timeout should not be cached
4 participants