frontend/dockerfile: add RunCommand.FlagsUsed field #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Let me add the new option to |
The FlagsUsed contains a list of flags that were used, which allows the classic (non-buildkit) builder in dockerd to produce an error when non-supported options are used in a Dockerfile. This is a short-term solution; a more permanent solution will be to keep track of which version of the Dockerfile syntax is supported, and to have the classic builder pass the maximum supported version of the syntax. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
dockerfile_export_flags_used
branch
from
6d96fdf to
ebed917
Compare
|
Added some tests |
|
@tonistiigi ptal (let me know if you're ok with this, or prefer to directly go for the "correct" approach) |
tonistiigi
approved these changes
Feb 3, 2021
AkihiroSuda
approved these changes
Feb 4, 2021
This was referenced Feb 22, 2021
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FlagsUsed contains a list of flags that were used, which allows the classic (non-buildkit) builder in dockerd to produce an error when non-supported options are used in a Dockerfile.
This is a short-term solution; a more permanent solution will be to keep track of which version of the Dockerfile syntax is supported, and to have the classic builder pass the maximum supported version of the syntax.