Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/containerd/stargz-snapshotter to v0.2.0 #1885

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

ktock
Copy link
Collaborator

@ktock ktock commented Dec 9, 2020

Related: containerd/stargz-snapshotter#190

This enables BuildKit to lazily pull eStargz with new footer format.

Full diff: containerd/stargz-snapshotter@3a04e4c...v0.2.0

@ktock
Copy link
Collaborator Author

ktock commented Dec 9, 2020

Job fails: codecov/patch — 0.00% of diff hit (target 46.19%)

@AkihiroSuda
Copy link
Member

Update Dockerfile as well

This enables BuildKit to lazily pull eStargz with new footer format.

Signed-off-by: ktock <[email protected]>
@ktock
Copy link
Collaborator Author

ktock commented Dec 10, 2020

How can we fix this? codecov/patch — 0.00% of diff hit (target 46.19%)

@crazy-max
Copy link
Member

@ktock Looks like codecov is broken (see #1830 (comment) and #1878). We can skip this failure in the meantime (cc. @coryb @tonistiigi). I will create a PR to try to fix that.

@ktock
Copy link
Collaborator Author

ktock commented Dec 15, 2020

Can we merge this? Codecov failure can be ignored according to #1885 (comment).

@AkihiroSuda
Copy link
Member

@tonistiigi PTAL

@tonistiigi tonistiigi merged commit 7880a4e into moby:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants