resolver: add better pooling and custom authenticator #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
resolver-pool
branch
from
eedd88e
to
4111533
Compare
|
hmm. some |
tonistiigi
force-pushed
the
resolver-pool
branch
from
e9fa571
to
ccb68e6
Compare
|
green now |
AkihiroSuda
reviewed
Aug 12, 2020
| @@ -71,7 +71,7 @@ require ( | |||
| ) | |||
|
|
|||
| replace ( | |||
| github.com/containerd/containerd => github.com/containerd/containerd v1.4.0-beta.2.0.20200728183644-eb6354a11860 | |||
| github.com/containerd/containerd => github.com/containerd/containerd v1.4.0-beta.2.0.20200730150746-fa1220fce33f | |||
There was a problem hiding this comment.
No objections for vendoring newer containerd. Was just trying to keep changes in this PR minimal and specific to the auth feature.
AkihiroSuda
approved these changes
Aug 13, 2020
sipsma
reviewed
Aug 13, 2020
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
resolver-pool
branch
from
ccb68e6
to
e650092
Compare
|
@sipsma Thanks. Updated |
This was referenced Aug 25, 2020
|
@tonistiigi I've got the same issue with GitHub Container Registry. Switching to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes all remote resolvers access through the new pooling functions.
Resolvers should now be always reused for concurrent access. Repeated access reuse tokens if they are still valid and if they have permissions to access them. Token expiring does not cause the build to fail anymore. The fallback order of request methods has been changed to avoid an extra request.
Some copy-paste in here can be removed when someone merges containerd/containerd#4445
In a follow-up I want to extend this to move token requests to the client. Could also add some authentication prediction for common registries but that probably will not be that significant atm.
@sipsma Added
WithSessionmethod to update existing resolver but didn't change anything about managing remotes yet. We can discuss these follow up changes after this is merged.