solver: avoid recursive loop on cache-export #1382
Merged
+52
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <[email protected]>
- to detect infinite loop caused by circular dependencies Signed-off-by: Anca Iordache <[email protected]> Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
|
Updated with a test based on #1386 . I think we can merge this as it fixes the critical issue and open follow-up issue for extra work on tooling and verification. cc @AkihiroSuda |
AkihiroSuda
approved these changes
Mar 3, 2020
bendavies
added a commit
to bendavies/docker-inline-cache-fail
that referenced
this pull request
Mar 9, 2020
bendavies
added a commit
to bendavies/docker-inline-cache-fail
that referenced
this pull request
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@drodriguezhdez @aiordache
This seems enough to fix the cycle issue (including a case with a longer cycle that doesn't appear with the original repro). But this area needs a bit more analysis, comments and maybe some debugging tooling to verify that the exported chain is still optimal, even in the cycle case. Also needs tests for the repros.
Signed-off-by: Tonis Tiigi [email protected]