Skip to content

Commit

Permalink
fix tests after busybox update
Browse files Browse the repository at this point in the history
Signed-off-by: Tonis Tiigi <[email protected]>
(cherry picked from commit b18c08c)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
  • Loading branch information
tonistiigi authored and thaJeztah committed Sep 14, 2020
1 parent 22e2307 commit 4dc8987
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions client/client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1335,7 +1335,7 @@ func testUser(t *testing.T, sb integration.Sandbox) {

run("daemon", `sh -c "id -nu > user"`)
run("daemon:daemon", `sh -c "id -ng > group"`)
run("daemon:nogroup", `sh -c "id -ng > nogroup"`)
run("daemon:nobody", `sh -c "id -ng > nobody"`)
run("1:1", `sh -c "id -g > userone"`)

st = st.Run(llb.Shlex("cp -a /wd/. /out/"))
Expand Down Expand Up @@ -1366,9 +1366,9 @@ func testUser(t *testing.T, sb integration.Sandbox) {
require.NoError(t, err)
require.Contains(t, string(dt), "daemon")

dt, err = ioutil.ReadFile(filepath.Join(destDir, "nogroup"))
dt, err = ioutil.ReadFile(filepath.Join(destDir, "nobody"))
require.NoError(t, err)
require.Contains(t, string(dt), "nogroup")
require.Contains(t, string(dt), "nobody")

dt, err = ioutil.ReadFile(filepath.Join(destDir, "userone"))
require.NoError(t, err)
Expand Down
8 changes: 4 additions & 4 deletions frontend/dockerfile/dockerfile_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2795,7 +2795,7 @@ FROM busybox AS base
ENV owner 1000
RUN mkdir -m 0777 /out
COPY --chown=daemon foo /
COPY --chown=1000:nogroup bar /baz
COPY --chown=1000:nobody bar /baz
ARG group
COPY --chown=${owner}:${group} foo /foobis
RUN stat -c "%U %G" /foo > /out/fooowner
Expand Down Expand Up @@ -2831,7 +2831,7 @@ COPY --from=base /out /
},
FrontendAttrs: map[string]string{
"build-arg:BUILDKIT_DISABLE_FILEOP": strconv.FormatBool(!isFileOp),
"build-arg:group": "nogroup",
"build-arg:group": "nobody",
},
LocalDirs: map[string]string{
builder.DefaultLocalNameDockerfile: dir,
Expand All @@ -2846,11 +2846,11 @@ COPY --from=base /out /

dt, err = ioutil.ReadFile(filepath.Join(destDir, "subowner"))
require.NoError(t, err)
require.Equal(t, "1000 nogroup\n", string(dt))
require.Equal(t, "1000 nobody\n", string(dt))

dt, err = ioutil.ReadFile(filepath.Join(destDir, "foobisowner"))
require.NoError(t, err)
require.Equal(t, "1000 nogroup\n", string(dt))
require.Equal(t, "1000 nobody\n", string(dt))
}

func testCopyOverrideFiles(t *testing.T, sb integration.Sandbox) {
Expand Down

0 comments on commit 4dc8987

Please sign in to comment.