Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

731 improve errorhandling #736

Merged
merged 15 commits into from
Jan 7, 2017
Merged

731 improve errorhandling #736

merged 15 commits into from
Jan 7, 2017

Conversation

mweststrate
Copy link
Member

@mweststrate mweststrate commented Jan 6, 2017

Fixes #731

  • computed values that throw, store the exception and throw it to the next consumer(s). They keep tracking their data, so they are able to recover
  • reactions will always catch their exceptions, and just log the error. They will keep tracking their data, so they are able to recover
  • the disposer of a reaction exposes an onError(handler) function to be able to attach custom error handling logic to an reaction (this intercepts the default behavior)
  • extras.onReactionError can be used to register a global onError handler for reactions (will fire after spy "error" event

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 96.526% when pulling daf2282 on 721-improve-errorhandling into 7f859eb on mobx3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants