Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor max iterations exception message #475

Merged
merged 1 commit into from
Aug 11, 2016
Merged

Refactor max iterations exception message #475

merged 1 commit into from
Aug 11, 2016

Conversation

igncp
Copy link
Contributor

@igncp igncp commented Aug 11, 2016

Hi,

Updated the exception message for cyclic reactions. It is a matter of taste, so just wanted to check your opinion. I hope it helps.

Cheers

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.931% when pulling fddf32b on igncp:master into 59a14f0 on mobxjs:master.

@mweststrate
Copy link
Member

@igncp yep that is better! Thanks for the contribution :)

@mweststrate mweststrate merged commit caaf7c8 into mobxjs:master Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igncp @coveralls @mweststrate