Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concider object with null prototype a plain object #473

Merged
merged 1 commit into from
Aug 11, 2016
Merged

Concider object with null prototype a plain object #473

merged 1 commit into from
Aug 11, 2016

Conversation

andykog
Copy link
Member

@andykog andykog commented Aug 10, 2016

isPlainObject(Object.create(null)) should return true

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 92.941% when pulling a9d7956 on andykog:plainObjectNoPrototype into 59a14f0 on mobxjs:master.

@mweststrate
Copy link
Member

Nice catch!

@mweststrate mweststrate merged commit 80495c0 into mobxjs:master Aug 11, 2016
@mavericken
Copy link

I actually just needed this today. Thanks!

@mweststrate
Copy link
Member

Released as 2.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andykog @coveralls @mweststrate @mavericken