[undecorate] partial fix for #3460: @action => override #3478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 15879ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Great, now it fails on facebook/jscodeshift#424 |
urugator
commented
Feb 5, 2023
| @@ -217,22 +217,22 @@ Note that it is possible to pass `{ proxy: false }` as an option to `observable` | |||
|
|
|||
There was a problem hiding this comment.
Probably done by precommit pretty hook
urugator
commented
Feb 5, 2023
| @@ -85,6 +85,7 @@ It's a bit opinionated and can lead to a lot of false positives depending on you | |||
| ### mobx/no-anonymous-observer (deprecated) | |||
|
|
|||
| _Deprecated in favor of [react/display-name](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/display-name.md) + [componentWrapperFunctions](https://github.com/jsx-eslint/eslint-plugin-react). Example of **.eslintrc**:_ | |||
|
|
|||
There was a problem hiding this comment.
Probably done by precommit pretty hook
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overridekeyword isn't preserved forkeepDecorators: false. Not sure if it's due to #1151 or if there an issue on our side.That's why test are failing, but it's possible to adapt them.
Does not support
decorateMay leave unused
actionimport.