Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct spellings #2101

Merged
merged 1 commit into from
Sep 10, 2019
Merged

correct spellings #2101

merged 1 commit into from
Sep 10, 2019

Conversation

Jongkeun
Copy link

Thanks for taking the effort to create a PR!

If you are creating an extensive PR, you might want to open an issue with your idea first, so that you don't put a lot of effort in an PR that wouldn't be accepted. Please prepend pull requests with WIP: if they are not yet finished
PR checklist:

  • Added unit tests
  • Updated changelog
  • Updated docs (either in the description of this PR as markdown, or as separate PR on the gh-pages branch. Please refer to this PR). For new functionality, at least API.md should be updated
  • Added typescript typings
  • Verified that there is no significant performance drop (npm run perf)

Feel free to ask help with any of these boxes!

The above process doesn't apply to doc updates etc.


I forked mobx just before to contribute many thing forward.
I fixed spellings.
I don't know if you need or not, but I think better it has right spelling.
Thanks.

@Jongkeun
Copy link
Author

What happened to this?
Do I have to do extra something?

@danielkcz
Copy link
Contributor

No, don't worry, it's false positive because CircleCI is not configured in gh-pages branch. Thanks for fixes.

@danielkcz danielkcz merged commit cd28d15 into mobxjs:gh-pages Sep 10, 2019
@Jongkeun
Copy link
Author

@FredyC Okay got it.
Thanks.👍

@cloverich cloverich mentioned this pull request Sep 13, 2019
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants