Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for #2079 #2082

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Docs for #2079 #2082

merged 1 commit into from
Oct 2, 2019

Conversation

Bnaya
Copy link
Member

@Bnaya Bnaya commented Aug 19, 2019

Docs for #2079

docs/refguide/api.md Show resolved Hide resolved
docs/refguide/api.md Outdated Show resolved Hide resolved
Copy link
Contributor

@danielkcz danielkcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think it's good enough docs, but let's wait how the actual code turns out to be before merging.

@mweststrate
Copy link
Member

I think it would be great if section 4.6 and/or 8.4 could be extended, hinting how these features could be used to detect mistakes

reactionRequiresObservable & observablesRequiresReaction
@Bnaya
Copy link
Member Author

Bnaya commented Sep 30, 2019

Merge it after release?

@mweststrate mweststrate merged commit af410a3 into gh-pages Oct 2, 2019
@danielkcz danielkcz deleted the gh-pages-#2079 branch October 2, 2019 13:03
@danielkcz danielkcz mentioned this pull request Oct 2, 2019
29 tasks
@Bnaya
Copy link
Member Author

Bnaya commented Oct 2, 2019

I don't see it in the docs site,
What's the status of gh-pages publishing?

@mweststrate
Copy link
Member

mweststrate commented Oct 3, 2019 via email

cloverich added a commit that referenced this pull request Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants