-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow overwriting computed values if configured #2011
Allow overwriting computed values if configured #2011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a warning to docs it shouldn't be abused for regular code, as a test tool it certainly could be useful. Although, I would say that a test that also checks if computed is working properly is more robust than some hacked value.
You should also update changelog, otherwise LGTM.
@FredyC thank you for the quick response. I've updated the package.json and will create a separate PR on the gh-pages branch to update the docs. |
I wonder, you have linked #1888 which is clearly about MobX 5 and yet you are doing this change in V4 only? Can you please also make another PR with merge to Besides, your docs PR is updating V5 docs, so it should definitely exist in that version :) |
You're right @FredyC - updating all related PRs. |
Last 4 PRs are mine... @FredyC - Is there anything else that needs to be done on my side? |
We ran into a problem where we couldn't overwrite computed properties in tests. Some of our computed properties are very complicated and it would be easier to just overwrite them in tests rather than overwrite the depending properties.
This fixes #1888 and #1867)
PR FOR MOBX 5
npm run perf
)