Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'set' support for observable sets #1945

Merged
merged 5 commits into from
Apr 15, 2019
Merged

Conversation

xaviergonz
Copy link
Contributor

@xaviergonz xaviergonz commented Apr 12, 2019

Thanks for taking the effort to create a PR!

If you are creating an extensive PR, you might want to open an issue with your idea first, so that you don't put a lot of effort in an PR that wouldn't be accepted. Please prepend pull requests with WIP: if they are not yet finished
PR checklist:

  • Added unit tests
  • Updated changelog
  • Updated docs (either in the description of this PR as markdown, or as separate PR on the gh-pages branch. Please refer to this PR). For new functionality, at least API.md should be updated
  • Added typescript typings
  • Verified that there is no significant performance drop (npm run perf)

Feel free to ask help with any of these boxes!

The above process doesn't apply to doc updates etc.

@xaviergonz xaviergonz changed the title add set for observable sets add 'set' for observable sets, fix observable set keys not being reactive Apr 12, 2019
@xaviergonz xaviergonz changed the title add 'set' for observable sets, fix observable set keys not being reactive add 'set' for observable sets Apr 12, 2019
@xaviergonz xaviergonz changed the title add 'set' for observable sets add 'set' support for observable sets Apr 12, 2019
@xaviergonz xaviergonz requested a review from mweststrate April 12, 2019 18:34
@coveralls
Copy link

coveralls commented Apr 12, 2019

Coverage Status

Coverage increased (+0.05%) to 93.927% when pulling 8e40450 on add-set-for-observable-sets into 805c02d on master.

@xaviergonz xaviergonz merged commit 9129e99 into master Apr 15, 2019
@xaviergonz xaviergonz deleted the add-set-for-observable-sets branch April 15, 2019 14:29
@mweststrate
Copy link
Member

Released as 4.10.0 / 5.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants