support cjs and esm version for browser builds #1834
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been running into issues with basic usage of mobx, where in a complete esm environment, a
import * as mobx from 'mobx'
webpack would still require the cjs version of mobx, though, amodule
entry is there and also defined within thepackage.json
. This caused a lot of headache, as there was no reason to do so.However, due to some weird behaviour, webpack 4 refuses to load the module version of mobx, until I've added the
browser
field topackage.json
.Everything should still work correctly within a commonjs environment, as a require call to mobx within the browser still requires the cjs version. Thanks a lot to https://github.com/stereobooster/main-module-browser-test for the idea behind this.
This works reliable for me, so it would be great to get this merged in!