Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interest in removing custom Iterator interface in Flow types? #1624

Closed
1 task done
adunham-stripe opened this issue Jul 5, 2018 · 2 comments
Closed
1 task done

Comments

@adunham-stripe
Copy link

I have a:

  1. Question: Feel free to just state your question. For a quick answer, there are usually people online at our Gitter channel

MobX currently defines a custom Iterator interface that is used for stuff like ObservableMap.keys(), etc. This conflicts with the built-in Flow Iterator interface, and, in particular, is missing Flow's current @@iterator hack to recognize iterators. This essentially means that you can't use Array.from or similar methods with MobX types, since Flow doesn't recognize them as iterators.

I've tested just removing the Iterator interface from the Flow definitions in MobX, and everything seems to work fine, but I'd like to gauge others' interest before submitting a PR that does this.

@mweststrate
Copy link
Member

Implemented, will be part of next release

@lock
Copy link

lock bot commented Jul 21, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs or questions.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants