Merge pull request #1529 from AmazingTurtle/patch-1

Changed illegal access error to a warning
mobxjs · May 22, 2018 · ac79559 · ac79559
2 parents b0371bf + e61e8c9
commit ac79559
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 9 deletions.
diff --git a/src/types/observableobject.ts b/src/types/observableobject.ts
@@ -182,7 +182,7 @@ export class ObservableObjectAdministration
          *
          * When using decorate, the property will always be redeclared as own property on the actual instance
          */
-        return fail(
+        console.warn(
             `Property '${propName}' of '${owner}' was accessed through the prototype chain. Use 'decorate' instead to declare the prop or access it statically through it's owner`
         )
     }

diff --git a/test/base/observables.js b/test/base/observables.js
@@ -1669,14 +1669,6 @@ test("Issue 1092 - Should not access attributes of siblings in the prot. chain",
     // sibling child1
     expect(typeof child2.attribute).toBe("undefined")
 
-    // We still should be able to read the value from the parent
-    expect(() => {
-        child2.staticObservable
-    }).toThrow(/accessed through the prototype chain/)
-    expect(() => {
-        child2.staticObservable = 3
-    }).toThrow(/accessed through the prototype chain/)
-
     expect(parent.staticObservable).toBe(11)
     parent.staticObservable = 12
     expect(parent.staticObservable).toBe(12)