Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: publish action should run on the main branch #965

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

amondnet
Copy link
Collaborator

@amondnet amondnet commented Dec 6, 2023

Describe the changes proposed in this Pull Request.

@pavanpodila

After renaming the master branch to main, publish is not running.


Pull Request Checklist

  • If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • Increment the major/minor/patch/patch-count, depending on the complexity of change
  • Add the necessary unit tests to ensure the coverage does not drop
  • Update the Changelog to include all changes made in this PR, organized by version
  • Run the melos run set_version command from the root directory
  • Include the necessary reviewers for the PR
  • Update the docs if there are any API changes or additions to functionality

Copy link

netlify bot commented Dec 6, 2023

👷 Deploy request for mobx pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 1966d75

@amondnet amondnet changed the title ci: publish actions should run on the main branch ci: publish action should run on the main branch Dec 6, 2023
@amondnet amondnet self-assigned this Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #965 (1966d75) into main (d14a27e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #965   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files          57       57           
  Lines        2005     2005           
=======================================
  Hits         1985     1985           
  Misses         20       20           
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 98.56% <ø> (ø)
mobx_codegen 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d14a27e...1966d75. Read the comment docs.

@pavanpodila pavanpodila merged commit 1388bbd into mobxjs:main Dec 6, 2023
8 checks passed
@amondnet amondnet deleted the ci-migrate-to-main branch December 6, 2023 09:29
@amondnet
Copy link
Collaborator Author

amondnet commented Dec 6, 2023

I temporarily recreated the master branch. Since the pr has been merged, I will delete the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants