Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing analysis errors #1021

Merged
merged 2 commits into from
Oct 26, 2024
Merged

fixing analysis errors #1021

merged 2 commits into from
Oct 26, 2024

Conversation

amondnet
Copy link
Collaborator

@amondnet amondnet commented Oct 26, 2024

Describe the changes proposed in this Pull Request.

If the PR fixes a specific issue, reference the issue with Fixes #.


Pull Request Checklist

  • If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • Increment the major/minor/patch/patch-count, depending on the complexity of change
  • Add the necessary unit tests to ensure the coverage does not drop
  • Update the Changelog to include all changes made in this PR, organized by version
  • Run the melos run set_version command from the root directory
  • Include the necessary reviewers for the PR
  • Update the docs if there are any API changes or additions to functionality

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.50%. Comparing base (0d2bcbb) to head (6fad6ea).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              main    #1021      +/-   ##
===========================================
- Coverage   100.00%   99.50%   -0.50%     
===========================================
  Files            6       57      +51     
  Lines          100     2019    +1919     
===========================================
+ Hits           100     2009    +1909     
- Misses           0       10      +10     
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 99.28% <ø> (?)
mobx_codegen 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
mobx_codegen/lib/src/type_names.dart 100.00% <ø> (ø)

... and 50 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d2bcbb...6fad6ea. Read the comment docs.

@amondnet amondnet merged commit ff616d9 into mobxjs:main Oct 26, 2024
7 checks passed
@amondnet amondnet deleted the analyzer-6.10.0 branch October 26, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants