Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#905: Introduce types.integer #935

Merged
merged 4 commits into from
Jul 25, 2018
Merged

#905: Introduce types.integer #935

merged 4 commits into from
Jul 25, 2018

Conversation

jayarjo
Copy link
Member

@jayarjo jayarjo commented Jul 19, 2018

No description provided.

@jayarjo
Copy link
Member Author

jayarjo commented Jul 22, 2018

I should apparently restrict exception test to NODE_ENV=development only.

@mweststrate
Copy link
Member

Looking great!

@mweststrate mweststrate merged commit bde78b5 into mobxjs:master Jul 25, 2018
@mweststrate
Copy link
Member

@jayarjo will release later today. Let me know if you want to join the mobx organisation to simplify further contributions! (It means that you can make changes on this repository, which makes branches, future PRs and such a lot simpler as you don't need to sync your own fork)

mweststrate added a commit that referenced this pull request Jul 26, 2018
@mweststrate
Copy link
Member

Released as 3.0.2 (I reverted the type inference to integers, as that would be a breaking change)

@jayarjo
Copy link
Member Author

jayarjo commented Jul 26, 2018

Didn't expect it to be merged so fast, for exactly such arguable reasons - having integer numbers to suddenly default to whole new type was definitely one of them :/

Let me know if you want to join the mobx organisation to simplify further contributions!

@mweststrate that'd be very interesting for sure!

@mweststrate
Copy link
Member

@jayarjo yep, my mistake! Forgot to look to the comments and missed it during the review

@jayarjo jayarjo deleted the #905 branch July 26, 2018 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants