Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Mobx 5 support #868

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Conversation

jeffberry
Copy link
Contributor

No description provided.

@mweststrate
Copy link
Member

I see why this fail, and check if I can fix it :)

@mweststrate mweststrate merged commit 39a4498 into mobxjs:master Jun 18, 2018
@jeffberry
Copy link
Contributor Author

jeffberry commented Jun 18, 2018

Thanks @mweststrate, just FYI in case you didn't see it - this PR went along with this over on the mobx repo: mobxjs/mobx#1589

Looking forward to using Proxied arrays finally! 😛

EDIT: Just saw you got it all working another way - so ignore and/or close my PR above. Thanks for all the work! Now that I've got the repos set up for development locally, I'll gladly help out where I can -- we're using this quite heavily in our projects.

@jeffberry jeffberry deleted the feature/mobx5-support branch June 18, 2018 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants