Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get parent of type #767

Merged
merged 2 commits into from
May 4, 2018
Merged

Get parent of type #767

merged 2 commits into from
May 4, 2018

Conversation

k-g-a
Copy link
Member

@k-g-a k-g-a commented Apr 13, 2018

Implements #477
Unfortunately I couldn't generate API.md properly. It converts

-   [addDisposer](#adddisposer)

into

-   [addDisposer][1]

And adds

[1]: #adddisposer

at the end of API.md

This leads to failure of two api tests.

@mweststrate
Copy link
Member

@k-g-a thanks! no worries about the docs, we can look into that. The tool is a bit fragile indeed :-/

@mweststrate mweststrate merged commit 3fa9e3e into mobxjs:master May 4, 2018
@k-g-a k-g-a deleted the get-parent-of-type branch May 10, 2018 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k-g-a @mweststrate @kga-kontur