-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add applyPatch test case for reference array #186
Add applyPatch test case for reference array #186
Conversation
test/reference.ts
Outdated
this.hovers.push(item) | ||
}, | ||
removeHover(item) { | ||
this.hovers = this.hovers.filter(i => i.id === item.id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: same as this.hovers.remove(item)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For removeHover
, should be !==
, or use remove
9d8ea73
to
905ee6a
Compare
Ok, I think I got where the problem is, basically after the item is removed from the array, dehanceValues is called and calls getValue over the reference, that has'nt got yet an identifier cache. |
Found another place, just called
|
@cpunion Thanks again for reporting and for your test! Can you please update this branch from master, and add an example fail case for applySnapshot as separate test? :) Thanks again! :) |
Sure, I will try. :) |
b8e35d2
to
51868e7
Compare
Added a test case, and rebased on master. |
51868e7
to
566e4e1
Compare
Nice! Seems to be fixed! Thanks for your help @cpunion! :) (will be out soon with another fix :P) |
Yeah! Thanks! Please cut a release today, I was blocked. :) |
See #185