Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arguments wrong in action after manipulation in middleware #731

Closed
robinfehr opened this issue Mar 25, 2018 · 0 comments · Fixed by #732
Closed

arguments wrong in action after manipulation in middleware #731

robinfehr opened this issue Mar 25, 2018 · 0 comments · Fixed by #732
Assignees
@robinfehr
Labels
bug Confirmed bug has PR A Pull Request to fix the issue is available

Comments

@robinfehr
Copy link
Contributor

arguments altered within a middleware

e.g.

next({ ...call, args: [call.args[0].toUpperCase()] });

do not reach the action.
within the action we still have the baseCall.arguments
@robinfehr robinfehr added the bug Confirmed bug label Mar 25, 2018
@robinfehr robinfehr self-assigned this Mar 25, 2018
@robinfehr robinfehr added the help/PR welcome Help/Pull request from contributors to fix the issue is welcome label Mar 25, 2018
@robinfehr robinfehr changed the title arguments wrong in action after manipulation arguments wrong in action after manipulation in middleware Mar 25, 2018
@robinfehr robinfehr mentioned this issue Mar 25, 2018
Closed
robinfehr added a commit to robinfehr/mobx-state-tree that referenced this issue Mar 25, 2018
@robinfehr
mobxjs#731 alter args of a call within a middleware
9c4c346
@robinfehr robinfehr mentioned this issue Mar 25, 2018
Merged
@robinfehr robinfehr added has PR A Pull Request to fix the issue is available and removed help/PR welcome Help/Pull request from contributors to fix the issue is welcome labels Mar 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robinfehr robinfehr

Labels
bug Confirmed bug has PR A Pull Request to fix the issue is available
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

alter args of a call within a middleware robinfehr/mobx-state-tree
1 participant
@robinfehr