Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for multiple packages (for monorepo) #36

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

philippeauriach
Copy link
Member

@philippeauriach philippeauriach commented Aug 30, 2023

What does it do? Why?

This make sure every package.json file is checked, and it improves the regex to catch those dependencies:

    "@mobsuccess-devops/lcm-react-client": "1.0.6014404762-pr-536",
    "@mobsuccess-devops/lcm-react-client": "pr-536",

@github-actions github-actions bot added the core Core Feature label Aug 30, 2023
@philippeauriach philippeauriach marked this pull request as ready for review August 30, 2023 08:44
@ms-bot
Copy link
Contributor

ms-bot commented Aug 30, 2023

A review for this PR has been requested in Slack #mobsuccess-review-requested 👉

@philippeauriach philippeauriach enabled auto-merge (squash) August 30, 2023 08:46
if (/^@mobsuccess-devops/.test(name) && /-pr-(\d+)\.(\d+)$/.test(version)) {
if (
/^@mobsuccess-devops/.test(name) &&
/-?pr-(\d+)(\.(\d+))*$/.test(version) // matches -pr-1 or -pr-1.0 or -pr-1.0.0 or pr-1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vraiment utile le com ?

Copy link
Member

@maastrich maastrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philippeauriach philippeauriach merged commit 351539b into master Aug 31, 2023
@philippeauriach philippeauriach deleted the core/add-check-multiple-packages branch August 31, 2023 08:06
Copy link
Contributor

@etienne-mobsuccess etienne-mobsuccess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants