Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PullRequestTitleValid #31

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Conversation

philippeauriach
Copy link
Member

@philippeauriach philippeauriach commented Aug 23, 2022

What does it do? Why?

Allows more characters in the name of PR, such as :
Bump 🧳 package version
Update "this part between quotes"
Update @dependency

QA

@ms-bot
Copy link
Contributor

ms-bot commented Aug 23, 2022

A review for this PR has been requested in Slack #mobsuccess-review-requested 👉 https://mobsuccess.slack.com/archives/C02FDSTH4SE/p1661241096927899?thread_ts=1661240006.230429&cid=C02FDSTH4SE

@github-actions github-actions bot added the core Core Feature label Aug 23, 2022
@ms-bot
Copy link
Contributor

ms-bot commented Aug 23, 2022

A review for this PR has been requested in Slack #mobsuccess-review-requested 👉 https://mobsuccess.slack.com/archives/C02FDSTH4SE/p1661243082884179

@ms-bot
Copy link
Contributor

ms-bot commented Aug 23, 2022

A review for this PR has been requested in Slack #mobsuccess-review-requested 👉 https://mobsuccess.slack.com/archives/C02FDSTH4SE/p1661243139282919

Copy link
Contributor

@etienne-mobsuccess etienne-mobsuccess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pierresisson pierresisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pierresisson pierresisson merged commit 7d84f16 into master Aug 23, 2022
@pierresisson pierresisson deleted the core/update-pr-naming-regexp branch August 23, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants