Review remarks attended to, began paging impl #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some remarks rectified; Began paging implementation see ProgramDataSource embryo Use of Javadoc comment format ContentAdapter::ViewHolder code removed Superflous 40 entries setting removed Unneccessary itemPrefetch statement removed RecyclerView now root object in layout Reduced dataset 5000 limit to 1000 for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some remarks rectified;
Began paging implementation
see ProgramDataSource embryo
Use of Javadoc comment format
ContentAdapter::ViewHolder code removed
Superflous 40 entries setting removed
Unneccessary itemPrefetch statement removed
RecyclerView now root object in layout
Reduced dataset 5000 limit to 1000 for now