support b58 addresses' in view and summaries #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updates tx summary messages to include fog information - moves hashing on-device - updates summary reports with caching for full address info - updates UI with address rendering
ryankurte
force-pushed
the
feature/b58-addresses
branch
from
adbf55c
to
e4327aa
Compare
|
i've managed to hack down schnorrkel to require ~half the stack, which is enough to get things working on the nanosplus! now workin' out how to best propagate the required changes |
ryankurte
changed the title
briancorbin
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #20
prostwith a minimal proto file reproducing ofPrintableWrapper(avoiding grpc components ofmc-api)FogIds to summary messages as a compressed alternative to fog URLs, removesShortAddressHashas this is now derived on deviceShortAddressHashderivation from primitive types w/ tests againstmc-account-keystypesmc-account-keystypesthis is more alloc heavy than would be ideal, but, cannot currently be avoided due to
prost. we also can't sign fog authorities at the moment as the CSPRNG uses 10kb of stack all by itself, which is non-critical but should be addressed so we can display generated addresses in a manner consistent with the upstream app.tested running on the nanosplus, may need atomic polyfill for nanox depending on the outcome of #27