-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fog-Report - Helm chart improvements for consolidating fog instances. #3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgreat
force-pushed
the
one-fog-charts
branch
from
October 24, 2023 20:53
7f346e2
to
13da98c
Compare
jgreat
changed the title
WIP: Helm chart improvements for consolidating fog instances.
Fog-Report - Helm chart improvements for consolidating fog instances.
Oct 24, 2023
jgreat
requested review from
joekottke,
a team and
nick-mobilecoin
and removed request for
a team
October 24, 2023 20:55
jgreat
commented
Oct 24, 2023
jgreat
commented
Oct 24, 2023
jgreat
commented
Oct 24, 2023
joekottke
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious about the deletions, and a few comments. Non-blocking.
.internal-ci/helm/fog-services-config/templates/fog-report-configmap.yaml
Show resolved
Hide resolved
aweis89
pushed a commit
that referenced
this pull request
Oct 25, 2023
Merged
nick-mobilecoin
added a commit
that referenced
this pull request
Nov 10, 2023
* Fog ledger update prometheus metrics in main loop (#3649) Previously fog ledger would only report the ledger db metrics on startup and not update the values. Now fog ledger will continue to update the prometheus metrics in its main loop * break out fog-report chart (#3643) * fog-view - Helm chart improvements for consolidating fog instances (#3662) * break out fog-view chart * bump grpcio to 0.13 (#3674) * fog-ledger - Helm chart improvements for consolidating fog instances (#3668) * break out ledger chart and deprecate fog-services Co-authored-by: Nick Santana <[email protected]> * Remove fog-services charts. (#3675) * remove fog-services fog-service-config charts * remove client-responder-id labels. The value can exceed the k8s lable size limit * Update changelog for 5.1.0 release (#3676) * Bump versions to 5.1.0 (#3677) * fix port alignment for fog-ledger-router and grpc-gateway (#3687) * Update changelog for 5.1.1 (#3688) * Bump versions to 5.1.1 (#3689) --------- Co-authored-by: Jason Greathouse <[email protected]> Co-authored-by: Eran Rundstein <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to be able to build fog instances that have multiple copies of fog-report, fog-view-router and fog-ledger-router with appropriate ingress and secret alignment.