Remove uneeded use of into_iter()
#3623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 17, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
nick-mobilecoin
commented
Oct 17, 2023
nick-mobilecoin
commented
Oct 17, 2023
eranrund
approved these changes
Oct 17, 2023
nick-mobilecoin
force-pushed
the
nick/remove-unused-mut
branch
from
3fbeb06
to
02abc82
Compare
nick-mobilecoin
force-pushed
the
nick/idomatic-iterators
branch
from
f0568c1
to
a2ec33a
Compare
This was referenced Oct 17, 2023
Some other minor clippy changes - use slices for temporary locals instead of vec![]. - use `let _` instead of drop() on copy types. - Be explicit when creating a slice of type Range
nick-mobilecoin
force-pushed
the
nick/idomatic-iterators
branch
from
a2ec33a
to
d7dc174
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some other minor clippy changes
let _instead of drop() on copy types.