Use general term "attestation evidence" in watcher #3607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
nick-mobilecoin
force-pushed
the
nick/watcher-renames
branch
from
6bd4e5c
to
b2510ac
Compare
nick-mobilecoin
commented
Oct 6, 2023
nick-mobilecoin
commented
Oct 6, 2023
Previously `mc-watcher` used "verification report" or similar to refer to the `VerificationReport`. With the anticipated use of `DcapEvidence` `mc-watcher` has been updated to use a more generic term of "attestation evidence" where appropriate.
nick-mobilecoin
force-pushed
the
nick/watcher-renames
branch
from
b2510ac
to
944abab
Compare
eranrund
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
mc-watcherused "verification report" or similar to referto the
VerificationReport. With the anticipated use ofDcapEvidencemc-watcherhas been updated to use a more generic term of "attestationevidence" where appropriate.
I was making changes to watcher to support handling
DcapEvidenceand it seemed that many places whereverification_report(or similar) was used would be ambiguous to future maintainers. This renaming may be a bit aggressive or perhaps we should completely avoid it as this PR is larger than ideal.