Limit cargo sort to only modify incorrect files.
#3595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default `cargo sort` will *always* re-write every `Cargo.toml` file it processes. This causes the build system to see the files changed and results in re-compiling unnecessarily. Now `cargo sort` will only update a file if it deviates from the desired sorting order.
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
eranrund
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default
cargo sortwill always re-write everyCargo.tomlfileit processes. This causes the build system to see the files changed and
results in re-compiling unnecessarily. Now
cargo sortwill only updatea file if it deviates from the desired sorting order.
On my machine this took a no-op lint from 45 seconds down to 25 seconds