From instead of TryFrom for proto to prost
#3592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously some conversions in `mc-api` that were from protobuf types to prost types were implemented as `TryFrom`. Now these conversions are implemented as `From`. This allows for a more ergonomic API preventing callers from having to check for errors that really shouldn't happen in this conversion step.
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
nick-mobilecoin
commented
Sep 29, 2023
dolanbernard
approved these changes
Sep 29, 2023
Merge Activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously some conversions in
mc-apithat were from protobuf types toprost types were implemented as
TryFrom. Now these conversions areimplemented as
From. This allows for a more ergonomic API preventingcallers from having to check for errors that really shouldn't happen in
this conversion step.