Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dcap Evidence Serialization #3521

Merged
merged 17 commits into from
Aug 23, 2023
Merged

Dcap Evidence Serialization #3521

merged 17 commits into from
Aug 23, 2023

Conversation

dolanbernard
Copy link
Contributor

Support encoding DCAP evidence as a prost Message

Motivation

In order to send DCAP evidence over the network, Quote3 and Collateral should be placed into a prost Message. Since Quote3 and Collateral cannot derive Message, we can manually implement it for the enclosing type and serialize/deserialize them to/from Vec.

Future Work

Implement logic for handling old EPID vs new DCAP verification

Copy link
Collaborator

@nick-mobilecoin nick-mobilecoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor suggested tweaks

attest/untrusted/Cargo.toml Outdated Show resolved Hide resolved
attest/verifier/types/Cargo.toml Outdated Show resolved Hide resolved
attest/verifier/types/src/verification.rs Outdated Show resolved Hide resolved
attest/verifier/types/src/verification.rs Outdated Show resolved Hide resolved
attest/verifier/types/src/verification.rs Outdated Show resolved Hide resolved
attest/verifier/types/src/verification.rs Outdated Show resolved Hide resolved
attest/untrusted/src/sim.rs Show resolved Hide resolved
attest/verifier/types/src/verification.rs Show resolved Hide resolved
@dolanbernard dolanbernard merged commit 1e978cd into master Aug 23, 2023
20 checks passed
@dolanbernard dolanbernard deleted the dcap-evidence-serialization branch August 23, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants