Add verification of Debug bit off for release enclaves #3510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
nick-mobilecoin
commented
Aug 16, 2023
eranrund
approved these changes
Aug 16, 2023
|
@nick-mobilecoin started a stack merge that includes this pull request via Graphite. |
nick-mobilecoin
force-pushed
the
nick/quote-nonce
branch
2 times, most recently
from
cf532e3
to
037da6c
Compare
nick-mobilecoin
force-pushed
the
nick/debug-flag
branch
from
1456f10
to
2d51703
Compare
When an enclave is built for debug, a bit is set in the `Attributes`. The DCAP verifier now checks for this bit being set when it shouldn't be.
|
Graphite rebased this pull request as part of a merge. |
nick-mobilecoin
force-pushed
the
nick/debug-flag
branch
from
2d51703
to
b3ef396
Compare
|
@nick-mobilecoin merged this pull request with Graphite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an enclave is built for debug, a bit is set in the
Attributes.The DCAP verifier now checks for this bit being set when it shouldn't
be.