Add OID extensions to simulated signing certificates #3497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
nick-mobilecoin
commented
Aug 11, 2023
eranrund
approved these changes
Aug 14, 2023
nick-mobilecoin
force-pushed
the
nick/consolidate-certificate-generation
branch
from
779a96d
to
fe79d90
Compare
nick-mobilecoin
force-pushed
the
nick/add-oid-extensions
branch
from
9aec8d3
to
2e4be8f
Compare
Merged
|
@nick-mobilecoin started a stack merge that includes this pull request via Graphite. |
nick-mobilecoin
force-pushed
the
nick/consolidate-certificate-generation
branch
from
fe79d90
to
429059a
Compare
Base automatically changed from
nick/consolidate-certificate-generation
to
master
August 15, 2023 00:39
The quote signing certificates from `mc-attest-verifier` that are created for `sgx-sim` now provide the necessar DCAP SGX OID extensions in the leaf certificate.
|
Graphite rebased this pull request as part of a merge. |
nick-mobilecoin
force-pushed
the
nick/add-oid-extensions
branch
from
2e4be8f
to
857e054
Compare
|
@nick-mobilecoin merged this pull request with Graphite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quote signing certificates from
mc-attest-verifierthat arecreated for
sgx-simnow provide the necessar DCAP SGX OID extensionsin the leaf certificate.