expose Schnorrkel Error from mc-crypto-keys #3261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type is already exposed in public APIs of RistrettoPublic and various conversions, but it is not actually exported from the crate, so there is no way for downstream to name the type. This commit re-exports the type at crate level, which is already part of the public API anyways.
cbeck88
requested review from
jcape,
a team and
nick-mobilecoin
and removed request for
a team
There was a problem hiding this comment.
Curious what the use case is?
I may have missed other places, but this looks to be used in 3 places:
- RistrettoPublic::verify_digestable() which maps the error
- RistrettoPublic::veirfy_schnorrkel() which maps the error
- verify() which is exposed as
SignatureError
|
I have a service that calls It seems to me that there's no good reason that I shouldn't be able to do this. That's the idiom we typically use for stuff like this. |
nick-mobilecoin
approved these changes
Mar 20, 2023
voloshyn
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type is already exposed in public APIs of RistrettoPublic and various conversions, but it is not actually exported from the crate, so there is no way for downstream to name the type.
This commit re-exports the type at crate level, which is already part of the public API anyways.