chore(deps): bump bitflags from 1.3.2 to 2.0.1

[dependabot]

Bumps bitflags from 1.3.2 to 2.0.1.

Release notes

Sourced from bitflags's releases.

2.0.1

What's Changed

• Fix up some docs issues by @​KodrAus in bitflags/bitflags#309
• Make empty_flag() const. by @​tormeh in bitflags/bitflags#313
• Fix formatting of multi-bit flags with partial overlap by @​KodrAus in bitflags/bitflags#316
• Prepare for 2.0.1 release by @​KodrAus in bitflags/bitflags#317

New Contributors

• @​tormeh made their first contribution in bitflags/bitflags#313

Full Changelog: bitflags/bitflags@2.0.0...2.0.1

2.0.0

Major changes

This release includes some major changes over 1.x. If you use bitflags! types in your public API then upgrading this library may cause breakage in your downstream users.

⚠️ Serialization

You'll need to add the serde Cargo feature in order to #[derive(Serialize, Deserialize] on your generated flags types.

The default serialization format with serde has changed if you #[derive(Serialize, Deserialize)] on your generated flags types. It will now use a formatted string for human-readable formats and the underlying bits type for compact formats.

To keep the old format, see the https://github.com/KodrAus/bitflags-serde-legacy library.

⚠️ Traits

Generated flags types now derive fewer traits. You'll need to derive the following yourself:

#[derive(PartialEq, Eq, PartialOrd, Ord, Hash, Debug, Clone, Copy]

⚠️ Methods

The unsafe from_bits_unchecked method is now a safe from_bits_retain method.

You can add the following method to your generated types to keep them compatible:

#[deprecated = "use the safe `from_bits_retain` method instead"]
pub unsafe fn from_bits_unchecked(bits: T) -> Self {
    Self::from_bits_retain(bits)
}

where T is the underlying bits type you're using, such as u32.

What's Changed

• Fix a typo and call out MSRV bump by @​KodrAus in bitflags/bitflags#259

... (truncated)

Changelog

Sourced from bitflags's changelog.

2.0.1

What's Changed

• Fix up some docs issues by @​KodrAus in bitflags/bitflags#309
• Make empty_flag() const. by @​tormeh in bitflags/bitflags#313
• Fix formatting of multi-bit flags with partial overlap by @​KodrAus in bitflags/bitflags#316

New Contributors

• @​tormeh made their first contribution in bitflags/bitflags#313

Full Changelog: bitflags/bitflags@2.0.0...2.0.1

2.0.0

What's Changed

• Fix a typo and call out MSRV bump by @​KodrAus in bitflags/bitflags#259
• BitFlags trait by @​arturoc in bitflags/bitflags#220
• Add a hidden trait to discourage manual impls of BitFlags by @​KodrAus in bitflags/bitflags#261
• Sanitize Ok by @​konsumlamm in bitflags/bitflags#266
• Fix bug in Debug implementation by @​konsumlamm in bitflags/bitflags#268
• Fix a typo in the generated documentation by @​wackbyte in bitflags/bitflags#271
• Use SPDX license format by @​atouchet in bitflags/bitflags#272
• serde tests fail in CI by @​arturoc in bitflags/bitflags#277
• Fix beta test output by @​KodrAus in bitflags/bitflags#279
• Add example to the README.md file by @​tiaanl in bitflags/bitflags#270
• Iterator over all the enabled options by @​arturoc in bitflags/bitflags#278
• from_bits_(truncate) fail with composite flags by @​arturoc in bitflags/bitflags#276
• Add more platform coverage to CI by @​KodrAus in bitflags/bitflags#280
• rework the way cfgs are handled by @​KodrAus in bitflags/bitflags#281
• Split generated code into two types by @​KodrAus in bitflags/bitflags#282
• expose bitflags iters using nameable types by @​KodrAus in bitflags/bitflags#286
• Support creating flags from their names by @​KodrAus in bitflags/bitflags#287
• Update README.md by @​KodrAus in bitflags/bitflags#288
• Prepare for 2.0.0-rc.1 release by @​KodrAus in bitflags/bitflags#289
• Add missing "if" to contains doc-comment in traits.rs by @​rusty-snake in bitflags/bitflags#291
• Forbid unsafe_code by @​fintelia in bitflags/bitflags#294
• serde: enable no-std support by @​nim65s in bitflags/bitflags#296
• Add a parser for flags formatted as bar-separated-values by @​KodrAus in bitflags/bitflags#297
• Prepare for 2.0.0-rc.2 release by @​KodrAus in bitflags/bitflags#299
• Use strip_prefix instead of starts_with + slice by @​QuinnPainter in bitflags/bitflags#301
• Fix up some clippy lints by @​KodrAus in bitflags/bitflags#302
• Prepare for 2.0.0-rc.3 release by @​KodrAus in bitflags/bitflags#303
• feat: Add minimum permissions to rust.yml workflow by @​gabibguti in bitflags/bitflags#305

New Contributors

• @​wackbyte made their first contribution in bitflags/bitflags#271
• @​atouchet made their first contribution in bitflags/bitflags#272
• @​tiaanl made their first contribution in bitflags/bitflags#270
• @​rusty-snake made their first contribution in bitflags/bitflags#291
• @​fintelia made their first contribution in bitflags/bitflags#294

... (truncated)

Commits

• 8b43d2b Merge pull request #317 from KodrAus/cargo/2.0.1
• 836eabb update changelog
• 11de329 prepare for 2.0.1 release
• af44dcc Merge pull request #316 from KodrAus/fix/multi-bit-flag-fmt
• 5ba27cf use the iterator state as the source of extra bits
• c4c13dc add repro for multi-bit flags
• ad02711 Merge pull request #313 from tormeh/tormod/const-empty-flag
• 242f5e7 Make empty_flag() const.
• 2c12c2e Merge pull request #309 from bitflags/KodrAus-patch-3
• d1d153b fix up some docs issues
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[nick-mobilecoin]

Per https://github.com/bitflags/bitflags/releases/tag/2.0.0 the serialized format of bitflags changed

The default serialization format with serde has changed if you #[derive(Serialize, Deserialize)] on your generated flags types. It will now use a formatted string for human-readable formats and the underlying bits type for compact formats.

It looks like bitflags is only used in attest/core/src/error.rs.

I'm guessing this may result in clients unable to deserialize the error.

[awygle]

I'd suggest we should remove the bitflags dependency entirely and replace it with a manual implementation in the style of https://github.com/KodrAus/bitflags-serde-legacy

[jcape]

The only places we're using serde currently are:

1. Across enclave boundaries
2. In one place in SCP message payloads
3. Serde-JSON in mobilecoind-json and full-service.

Because we (generally) don't update dependencies without bumping the enclave version (we made an exception), and enclave upgrades are flag-days, I'm OK to continue using bitflags for this, TBH.

[dependabot]

A newer version of bitflags exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

[jcape]

LGTM, I'll assign someone to fix up the hysteresis so this can get merged.