release/V4.0 - fix(charts): fix blocklist logic #3048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgreat
requested review from
a team,
awygle and
nick-mobilecoin
and removed request for
a team
aweis89
approved these changes
Jan 26, 2023
nick-mobilecoin
approved these changes
Jan 27, 2023
This was referenced Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix blocklist enable logic. The configmap really only stores strings, so "false" as a string evaluates to
true. Fix this logic in the ingress if evaluations.This could be better, would prefer this to use proper boolean evaluation, but would require some pretty heavy refactoring and a change to deployment strategy.