Require C++11 if protobuf version >= 3.6.0 is installed #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shouldn't require C++11 when not required. This hack may not always detect when C++11 *is* required, in which case a little autoconf tweaking may be needed to get a good compile.
As predicted, 'brew unlink python' is no longer needed.
cgull
force-pushed
the
protobuf-req-c++11
branch
from
e6f9e09 to
7e600fe
Compare
Also stop using _exit(), believed unnecessary now with proper stdio flushing.
cgull
force-pushed
the
protobuf-req-c++11
branch
from
7e600fe to
ace6324
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On MacOS, Homebrew now pulls in protobuf 3.6.0, which requires c++11.
If anyone has a better way of doing this that doesn't impact c++03 builds, please do.
It's time for Mosh to move to C++11 or greater, but maybe not this release.