Report errors from mosh-server startup to the user #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Early exit from a block is clearer.
This allows its use for error messages in the parent-- used in the next commit.
I think this will help with the papercut of "Did not find mosh server startup message". This message confuses people; often the real problem is that the command to start the remote mosh-server failed somehow. Fixes mobile-shell#1042, partially resolves mobile-shell#1005. Also relevant for mobile-shell#1042 and countless questions on IRC.
|
#1211 is a recent example of an issue where I think this change will help. |
|
I misremembered, there's no |
|
Does this PR obsolete #1097 now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request mostly fixes a longtime irritant in Mosh-- the lack of error reporting when the
sshcommand to startmosh-servergoes sideways. It does this by rearranging some code inmosh-serverso the session information is sent before the server forks, and rearranging some code code inmosh.plso that the session information is captured in the parent, not the child. When those two things are done, thenmosh-servercan report some errors before it forks off into the sunset, andmosh.plcan usefully capture the exitstatus of the ssh command. There's a new test to check some of that too.fixes #1042
partially addresses #1005
and would have prevented countless questions on IRC.